[zeromq-dev] building zeromq 4.2.0 on AIX 7.1 broken?

[Luca Boccassi]

On Tue, 2016-11-29 at 20:59 +0000, Mike Beddo wrote:
> I can successfully build zeromq 4.1.6 on AIX 7.1 using "configure CC=xlc CXX=xlC" followed by make and make check. All tests passed.
> 
> When I try to do the same with zeromq 4.2.0 on AIX 7.1 there are compilation errors:
> 
> $ make
> Making all in doc
> make[1]: Entering directory `/home/meb/zeromq-4.2.0/doc'
> make[1]: Nothing to be done for `all'.
> make[1]: Leaving directory `/home/meb/zeromq-4.2.0/doc'
> make[1]: Entering directory `/home/meb/zeromq-4.2.0'
>   CXX      src/src_libzmq_la-proxy.lo
> "src/proxy.cpp", line 157.34: 1540-0217 (S) "rtnevents" is not a member of "struct zmq_pollitem_t".
> "src/proxy.cpp", line 188.22: 1540-0217 (S) "rtnevents" is not a member of "struct zmq_pollitem_t".
> "src/proxy.cpp", line 189.51: 1540-0217 (S) "rtnevents" is not a member of "struct zmq_pollitem_t".
> "src/proxy.cpp", line 197.22: 1540-0217 (S) "rtnevents" is not a member of "struct zmq_pollitem_t".
> "src/proxy.cpp", line 198.25: 1540-0217 (S) "rtnevents" is not a member of "struct zmq_pollitem_t".
> make[1]: *** [src/src_libzmq_la-proxy.lo] Error 1
> make[1]: Leaving directory `/home/meb/zeromq-4.2.0'
> make: *** [all-recursive] Error 1
> $

Uhm I'm a bit confused, this is the line at 157:

        if (control_ && items [2].revents & ZMQ_POLLIN) {

Maybe I'm missing something, but it's .revents not .rtnevents. This is
the struct in include/zmq.h:

typedef struct zmq_pollitem_t
{
    void *socket;
#if defined _WIN32
    SOCKET fd;
#else
    int fd;
#endif
    short events;
    short revents;
} zmq_pollitem_t;

> Also, I had to remove "-Wno-long-long" from the CPPFLAGS in the configure script for both zeromq 4.1.6 and 4.2.0 to avoid the warning message "Option -Wno-long-long was incorrectly specified. The option will be ignored."

This should then be stripped from CPPFLAGS in the AIX section of the
configure.ac script (line 247), or perhaps it's easier to add it for all
OSes but AIX. Could you please send a PR to do it?

Thanks!

Kind regards,
Luca Boccassi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <https://lists.zeromq.org/pipermail/zeromq-dev/attachments/20161130/2dc40752/attachment.sig>