[zeromq-dev] How to build a stable (non DRAFT_API) version of malamute?

[Osiris Pedroso]

Hi Kevin,

I tried running configure.bat —disable-drafts which comment says “from git
repository, disables DRAFT API”

But platform.h still have “#define CZMQ_BUILD_DRAFT_API” and it outputs:

c:\TFS_PPM_S3D\Current\3rdPartyComponents\OpenSrc\czmq\builds\msvc>configure.bat
--disable-drafts
Configuring CZMQ...
Building with libzmq
Building without systemd
Building with draft API (stable + legacy + draft API)

The batch script, instead of using the argument documented, instead checks
for the presence of the .git directory and if present, DRAFT_API is defined
no matter the arguments are.

:-  Check if we want to build the draft API
IF NOT EXIST "..\..\.git" GOTO no_draft
    ECHO Building with draft API (stable + legacy + draft API)
    ECHO //  Provide draft classes and methods>>platform.h
    ECHO #define CZMQ_BUILD_DRAFT_API 1>>platform.h
    GOTO end_draft
:no_draft
    ECHO Building without draft API (stable + legacy API)
    ECHO #undef CZMQ_BUILD_DRAFT_API 1>>platform.h
:end_draft

I can send a PR to fix this, but I want to know if this is another of those
“don’t touch subjects” that I should not waste my time on.

Appreciate your input,
Osiris

PS: this batch also has problems (like using the END label which is not
defined, for which I made a zproject PR to fix it over a week now, but
which seem to have been reverted).
On Tue, Apr 19, 2016 at 7:54 AM Kevin Sapper <kevinsapper88 at gmail.com>
wrote:

> Hi Osiris,
>
> have a look builds/msvc/configure.bat. configure.bat --help should give
> you more infos. I haven't used it though. There also a section "Build on
> Windows" in the czmq README which should apply to malamute as well.
>
> //Kevin
>
> 2016-04-19 14:32 GMT+02:00 Osiris Pedroso <opedroso at gmail.com>:
>
>> My environment is Windows.
>>
>> I need to know how to build the MALAMUTE library/dll without DRAFT_API
>> being defined.
>>
>> Same question applies to CZMQ, since MALAMUTE includes CZMQ as well.
>>
>> Is it just a matter of hand editing platform.h and commenting #define
>> MLM_BUILD_DRAFT_API?
>>
>> Thanks,
>> Osiris
>>
>>
>> _______________________________________________
>> zeromq-dev mailing list
>> zeromq-dev at lists.zeromq.org
>> http://lists.zeromq.org/mailman/listinfo/zeromq-dev
>>
>>
> _______________________________________________
> zeromq-dev mailing list
> zeromq-dev at lists.zeromq.org
> http://lists.zeromq.org/mailman/listinfo/zeromq-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.zeromq.org/pipermail/zeromq-dev/attachments/20160419/63569f83/attachment.htm>