[zeromq-dev] More Questions about C4.1

[Pieter Hintjens]

You're over thinking it... one commit per problem is nice. Multiple
commits in a pull request is typically fine too. It breaks the "pull
request = commit" assumption which you'll see C4.1 is fine with.

The simplest flow is to queue up commits and merge as many as you can
in one go. This works well IF people make one commit per problem and
write their commit messages properly.

-Pieter

On Wed, Jul 1, 2015 at 5:52 PM, Luna Duclos
<luna.duclos at palmstonegames.com> wrote:
> You could use one branch per PR and not have this problem.
>
> On Wed, Jul 1, 2015 at 5:44 PM, Paulmichael Blasucci <pblasucci at gmail.com>
> wrote:
>>
>> So, in general, it's one patch per problem -- which is good. However, the
>> way GitHub tacks subsequent commits onto existing pull requests presents a
>> bit of a dilemma. Do I keep piling up patches into one big merge? Or do I
>> wait for my pull request to be merged before sending over new changes? (or
>> am I over-thinking the whole process and/or missing some obvious feature of
>> GitHub?)
>>
>> Thanks!
>>
>>
>> _______________________________________________
>> zeromq-dev mailing list
>> zeromq-dev at lists.zeromq.org
>> http://lists.zeromq.org/mailman/listinfo/zeromq-dev
>>
>
>
> _______________________________________________
> zeromq-dev mailing list
> zeromq-dev at lists.zeromq.org
> http://lists.zeromq.org/mailman/listinfo/zeromq-dev
>