[zeromq-dev] CZMQ community & red cards

rf at q-leap.de rf at q-leap.de
Fri Oct 17 15:10:08 CEST 2014

>>>>> "Brian" == Brian Knox <bknox at digitalocean.com> writes:

    Roland> ----------------------------------------------------------------------------------
    Roland> Citation Brian
    Roland> (http://lists.zeromq.org/pipermail/zeromq-dev/2014-October/027554.html)
    Roland> "We do not merge everything and then fix it if it is
    Roland> broken. Your statement is empirically false."

    Roland> Citation Pieter (https://github.com/zeromq/czmq/pull/673):
    Roland> "I treat a pull request as a request to merge. I blindly
    Roland> merge everything, and fix up afterwards (or complain if that
    Roland> feels too painful) :-)"

    Roland> Hmm, which one is right now???
    Roland> ---------------------------------------------------------------------------------

    Brian> Here are the facts concerning my statement.

    Brian> 1) We have a continuous integration system in place
    Brian>    (travis-ci).

    Brian> 2) All pull requests to CZMQ are run through travis-ci
    Brian>    against multiple
    Brian> versions of libzmq:
    Brian> https://github.com/zeromq/czmq/blob/master/.travis.yml

    Brian> 3) When pull requests break the build on travis-ci,
    Brian>    discussion takes place
    Brian> and in general the requests are not merged until they are
    Brian> fixed.  These discussions are easy to find.

Sounds good. Thanks for the clarification. Unfortunately, breaking a
build is only one aspect of broken code ... and usually the most
harmless since easy to detect.

    Brian> 4) Nowhere in Pieter's statement does he say he merges broken
    Brian>    code.

In any case, the definition of "everything" as I know it, would mean
***everything*** which includes broken code. If you have a different
definition, please elaborate.


More information about the zeromq-dev mailing list