[zeromq-dev] zmq.h constants -> enums

Pieter Hintjens ph at imatix.com
Tue Oct 8 14:59:34 CEST 2013


OK, I'm going to take Alexey's comments as a veto for this change, and
remove it from libzmq master...

On Tue, Oct 8, 2013 at 12:56 PM, Alexey Melnichuk <mimir at newmail.ru> wrote:
> Pieter Hintjens <ph <at> imatix.com> writes:
>
>>
>> Hi all,
>>
>> Especially binding authors and those using ZeroMQ in C:
>>
>> There is a patch on libzmq master that replaces the macros in zmq.h
>> with enums. See
>> https://github.com/zeromq/libzmq/blob/master/include/zmq.h#L183
>>
>> The numeric values don't change but any code that depends on the
>> preprocessor seeing these macros will be affected. For CZMQ I only
>> check macros if ZMQ_VERSION_MAJOR is 2 or 3.
>>
>> Before I backport this to 4-x, I'd like some feedback; if the
>> consensus is that this change is too traumatic, we'll revert it on
>> libzmq master. Otherwise I'll pull it into the 4-x release.
>>
>
> I am athor of lua binding[1].
> For me macros are convinient because of i can just add one more ifdef
> and forget about that [2]. If some mocro was remove i do not need to wrap
> this macro to version detection `#if`.
>
> [1] https://github.com/moteus/lzmq
> [2] https://github.com/moteus/lzmq/blob/master/src/zsocket.c#L403
>
> _______________________________________________
> zeromq-dev mailing list
> zeromq-dev at lists.zeromq.org
> http://lists.zeromq.org/mailman/listinfo/zeromq-dev



More information about the zeromq-dev mailing list