[zeromq-dev] How do I send a minor patch?

[gonzalo diethelm]

OK, thanks for the summary. Done according to your instructions.

-- 
Gonzalo Diethelm
DCV Chile


> -----Original Message-----
> From: zeromq-dev-bounces at lists.zeromq.org [mailto:zeromq-dev-
> bounces at lists.zeromq.org] On Behalf Of Pieter Hintjens
> Sent: Thursday, June 20, 2013 12:33 PM
> To: ZeroMQ development list
> Subject: Re: [zeromq-dev] How do I send a minor patch?
> 
> The full process is defined here: http://rfc.zeromq.org/spec:22
> 
> In brief:
> 
> - fork the zeromq/libzmq repo to your own profile
> - clone it to your laptop
> - make the change, commit and push back to your own repo
> - go to your fork on github and make a pull request
> 
> That's it. We have continuous builds that will check if you broke something. If
> the change is contentious, discuss it here.
> 
> -Pieter
> 
> On Thu, Jun 20, 2013 at 6:21 PM, gonzalo diethelm <gdiethelm at dcv.cl>
> wrote:
> > I just made a minor modification to the library and am wondering how
> > to contribute it back. I committed in my local git repo; do I just
> > push it back to GitHub? Do I post the patch here? Both?
> >
> >
> >
> > For whatever is worth, the diff is pasted below. Thanks.
> >
> >
> >
> >
> >
> > diff --git a/.gitignore b/.gitignore
> >
> > index ce586a1..4996028 100644
> >
> > --- a/.gitignore
> >
> > +++ b/.gitignore
> >
> > @@ -67,6 +67,7 @@ bin/
> >
> > lib/
> >
> > obj/
> >
> > builds/msvc/*.suo
> >
> > +builds/msvc/*.sdf
> >
> > builds/msvc/*/*.user
> >
> > builds/msvc/*/*Debug
> >
> > builds/msvc/*/*Release
> >
> > @@ -78,4 +79,3 @@ foreign/openpgm/*
> >
> > zeromq-*.tar.gz
> >
> > zeromq-*.zip
> >
> > core
> >
> > -
> >
> > diff --git a/src/ctx.cpp b/src/ctx.cpp
> >
> > index 16a9d8a..f3f6fae 100644
> >
> > --- a/src/ctx.cpp
> >
> > +++ b/src/ctx.cpp
> >
> > @@ -35,8 +35,10 @@
> >
> > #include "err.hpp"
> >
> > #include "msg.hpp"
> >
> > +#define ZMQ_CTX_TAG_VALUE 0xabadcafe
> >
> > +
> >
> > zmq::ctx_t::ctx_t () :
> >
> > -    tag (0xabadcafe),
> >
> > +    tag (ZMQ_CTX_TAG_VALUE),
> >
> >      starting (true),
> >
> >      terminating (false),
> >
> >      reaper (NULL),
> >
> > @@ -50,7 +52,7 @@ zmq::ctx_t::ctx_t () :
> >
> >  bool zmq::ctx_t::check_tag ()
> >
> > {
> >
> > -    return tag == 0xabadcafe;
> >
> > +    return tag == ZMQ_CTX_TAG_VALUE;
> >
> > }
> >
> >  zmq::ctx_t::~ctx_t ()
> >
> >
> >
> > --
> >
> > Gonzalo Diethelm
> >
> > DCV Chile
> >
> >
> >
> > ________________________________
> >
> > Declaración de confidencialidad: Este Mensaje esta destinado para el
> > uso de la o las personas o entidades a quien ha sido dirigido y puede
> > contener información reservada y confidencial que no puede ser
> > divulgada, difundida, ni aprovechada en forma alguna. El uso no
> > autorizado de la información contenida en este correo podrá ser
> > sancionado de conformidad con la ley chilena. Si usted ha recibido
> > este correo electrónico por error, le pedimos eliminarlo junto con los
> > archivos adjuntos y avisar inmediatamente al remitente, respondiendo
> > este mensaje. Disclosure: This Message is to be used by the
> > individual, individuals or entities that it is addressed to and may
> > include private and confidential information that may not be
> > disclosed, made public nor used in any way at all. Unauthorized use of
> > the information in this electronic mail message may be subject to the
> > penalties set forth by Chilean law. If you have received this
> > electronic mail message in error, we ask you to destroy the message and its
> attached file(s) and to immediately notify the sender by answering this
> message.
> >
> > _______________________________________________
> > zeromq-dev mailing list
> > zeromq-dev at lists.zeromq.org
> > http://lists.zeromq.org/mailman/listinfo/zeromq-dev
> >
> _______________________________________________
> zeromq-dev mailing list
> zeromq-dev at lists.zeromq.org
> http://lists.zeromq.org/mailman/listinfo/zeromq-dev
----------------------------------------- 
Declaración de confidencialidad: Este Mensaje esta destinado para
el uso de la o las personas o entidades a quien ha sido dirigido y
puede contener información reservada y confidencial que no puede
ser divulgada, difundida, ni aprovechada en forma alguna. El uso no
autorizado de la información contenida en este correo podrá ser
sancionado de conformidad con la ley chilena. 
Si usted ha recibido este correo electrónico por error, le pedimos
eliminarlo junto con los archivos adjuntos y avisar inmediatamente
al remitente, respondiendo este mensaje. 

"Before printing this e-mail think if is really necesary".
Disclosure: This Message is to be used by the individual,
individuals or entities that it is addressed to and may include
private and confidential information that may not be disclosed,
made public nor used in any way at all. Unauthorized use of the
information in this electronic mail message may be subject to the
penalties set forth by Chilean law. 
If you have received this electronic mail message in error, we ask
you to destroy the message and its attached file(s) and to
immediately notify the sender by answering this message.