[zeromq-dev] zbeacon changes

Michael Haberler mail17 at mah.priv.at
Mon Dec 23 19:52:28 CET 2013


Am 23.12.2013 um 13:53 schrieb Pieter Hintjens <ph at imatix.com>:

> Michael,
> 
> I've been hacking on zbeacon and removed most of your new code (the
> unicast/send methods). The main reason is I don't think they belong
> there at all, and turns the zbeacon concept into a "UDP stuff happens
> here" class, which is not good.

fine with me, I wasnt sure of that being the right place and context either. I saw it as a transitory vehicle in a transitory place until the UDP transport is in place.

> - could you please sign your commits with your email that you used to
> login to GitHub? Right now your commits in GitHub aren't pointing to
> your user profile
> 
> - please don't use tabs, don't copy code, try to keep to the style guidelines

<haberler straigthens up> will read up and behave, sorry

> - I've started some UDP functions in zsys, and I think you can use
> these to build your unicast send/recv code.

where to peep?

> - What I'd suggest is you make a minimal set of methods that does what
> you need, and I'll help refactor those back into CZMQ.

these are:
- send a unicast packet to a given IP address
- listen on a UDP socket bound to INADDR_ANY
- have reception on that socket usable from zloop

I'm not sure my use case warrants this extra hoop; actually it's so trivial I would suggest dropping my code altogether for now and revisit once the UDP transport is in place because that's what it really should use. Everything else is just doubling up.

As far as my application goes, I can get by just fine with rather trivial socket I/O for now. 

thanks!

Michael




More information about the zeromq-dev mailing list