[zeromq-dev] merge commits in libzmq clutter the commit space.

[Lindley French]

I'm a fan of gitflow, I think it's great.

I'm still getting a feel for how the forking model works.


On Fri, Dec 6, 2013 at 6:10 PM, Pieter Hintjens <ph at imatix.com> wrote:

> it's because that project isn't using pull requests, but one person
> committing directly to master. We abandoned that model some years ago
> as inherently unstable and unscalable.
>
> On Fri, Dec 6, 2013 at 11:37 PM, crocket <crockabiscuit at gmail.com> wrote:
> > I just came by https://github.com/nanomsg/nanomsg/commits/master ,
> which is
> > M.sustrick's new endeavor, and I was surprised that it didn't have any
> merge
> > commits.
> > It looked cleaner than with github's usual merge commits.
> > So I wanted ZeroMQ people to just imagine another possibility.
> >
> >
> > On Sat, Dec 7, 2013 at 3:54 AM, Pieter Hintjens <ph at imatix.com> wrote:
> >>
> >> On Fri, Dec 6, 2013 at 4:41 PM, Michel Pelletier
> >> <pelletier.michel at gmail.com> wrote:
> >>
> >> > Feature developers should be responsible for squashing their commits
> >> > before
> >> > submitting the PR.  It's a simple git rebase command.
> >>
> >> Yes, and it's specified in our process that one change should be one
> >> commit. However it's the merge itself that adds another commit, which
> >> Crocket is referring to here.
> >> _______________________________________________
> >> zeromq-dev mailing list
> >> zeromq-dev at lists.zeromq.org
> >> http://lists.zeromq.org/mailman/listinfo/zeromq-dev
> >
> >
> >
> > _______________________________________________
> > zeromq-dev mailing list
> > zeromq-dev at lists.zeromq.org
> > http://lists.zeromq.org/mailman/listinfo/zeromq-dev
> >
> _______________________________________________
> zeromq-dev mailing list
> zeromq-dev at lists.zeromq.org
> http://lists.zeromq.org/mailman/listinfo/zeromq-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.zeromq.org/pipermail/zeromq-dev/attachments/20131206/f0498c99/attachment.htm>