[zeromq-dev] merge commits in libzmq clutter the commit space.

crocket crockabiscuit at gmail.com
Fri Dec 6 23:37:37 CET 2013


I just came by https://github.com/nanomsg/nanomsg/commits/master , which is
M.sustrick's new endeavor, and I was surprised that it didn't have any
merge commits.
It looked cleaner than with github's usual merge commits.
So I wanted ZeroMQ people to just imagine another possibility.


On Sat, Dec 7, 2013 at 3:54 AM, Pieter Hintjens <ph at imatix.com> wrote:

> On Fri, Dec 6, 2013 at 4:41 PM, Michel Pelletier
> <pelletier.michel at gmail.com> wrote:
>
> > Feature developers should be responsible for squashing their commits
> before
> > submitting the PR.  It's a simple git rebase command.
>
> Yes, and it's specified in our process that one change should be one
> commit. However it's the merge itself that adds another commit, which
> Crocket is referring to here.
> _______________________________________________
> zeromq-dev mailing list
> zeromq-dev at lists.zeromq.org
> http://lists.zeromq.org/mailman/listinfo/zeromq-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.zeromq.org/pipermail/zeromq-dev/attachments/20131207/cce77d53/attachment.htm>


More information about the zeromq-dev mailing list