[zeromq-dev] merge commits in libzmq clutter the commit space.

AJ Lewis aj.lewis at quantum.com
Fri Dec 6 16:44:50 CET 2013


On Fri, Dec 06, 2013 at 07:41:52AM -0800, Michel Pelletier wrote:
> Feature developers should be responsible for squashing their commits before
> submitting the PR.  It's a simple git rebase command.

Sorry, why do we care?  What's wrong with actually seeing the full history
of the feature/bug fix?  I find it useful (if the commits are actually
sane). 

AJ
 
> On Fri, Dec 6, 2013 at 5:08 AM, Pieter Hintjens <ph at imatix.com> wrote:
> 
> > As far as I know, it's unavoidable when we use pull requests.
> >
> > On Fri, Dec 6, 2013 at 7:54 AM, crocket <crockabiscuit at gmail.com> wrote:
> > > Is there a way to merge pull requests without introducing merge commits?
> > >
> > > _______________________________________________
> > > zeromq-dev mailing list
> > > zeromq-dev at lists.zeromq.org
> > > http://lists.zeromq.org/mailman/listinfo/zeromq-dev
> > >
> > _______________________________________________
> > zeromq-dev mailing list
> > zeromq-dev at lists.zeromq.org
> > http://lists.zeromq.org/mailman/listinfo/zeromq-dev
> >

> _______________________________________________
> zeromq-dev mailing list
> zeromq-dev at lists.zeromq.org
> http://lists.zeromq.org/mailman/listinfo/zeromq-dev


-- 
AJ Lewis
Software Engineer
Quantum Corporation

Work:    651 688-4346
email:   aj.lewis at quantum.com

----------------------------------------------------------------------
The information contained in this transmission may be confidential. Any disclosure, copying, or further distribution of confidential information is not permitted unless such privilege is explicitly granted in writing by Quantum. Quantum reserves the right to have electronic communications, including email and attachments, sent across its networks filtered through anti virus and spam software programs and retain such messages in order to comply with applicable data security and retention requirements. Quantum is not responsible for the proper and complete transmission of the substance of this communication or for any delay in its receipt.



More information about the zeromq-dev mailing list