[zeromq-dev] Absolute vs relative recurring timers in zloop

Pieter Hintjens ph at imatix.com
Wed Oct 24 08:58:31 CEST 2012


Hi Roger,

I see you made the pull request but ignored my suggestions to fix the
code style and provide a test case.

Could you fix the code and make the pull request again?

Thanks
Pieter

On Wed, Oct 24, 2012 at 9:26 AM, Pieter Hintjens <ph at imatix.com> wrote:
> Hi Roger,
>
> Patches are always welcome and it looks like you're fixing an old
> problem in the timer design.
>
> Please do read the contribution process at
> http://rfc.zeromq.org/spec:16 and make sure your code fits the
> existing CZMQ style in terms of names, layout, etc. Then make a pull
> request, and we'll merge it.
>
> Key points for patches:
>
> * you can extend APIs but not break them
> * if you're fixing bugs, provide a minimal test case
> * stick to the code style
> * use GutHub pull requests
>
> Thanks
> Pieter
>
>
>
> On Wed, Oct 24, 2012 at 6:35 AM, Roger <sponsoredlinks at hotmail.com> wrote:
>>
>> Hi, apologies if this has been covered already - I did a quick search but
>> couldn't see it specifically mentioned.
>>
>> While running a recurring timer within zloop I noticed that it drifts over
>> time, as it sets a time relative to when the execution loop is triggered,
>> rather than an absolute time based on when it was expected to last fire.
>>
>> I couldn't see this mentioned as expected behaviour, and it causes
>> significant drift over time (on windows at least - linux is less severe :)
>>
>> I've uploaded some thoughts in a patch (below) if someone more
>> experienced than me is interested in having a think about whether
>> this might be worth adding/updating
>>
>> thanks
>>
>> Roger
>>
>> https://gist.github.com/3941724
>>
>> _______________________________________________
>> zeromq-dev mailing list
>> zeromq-dev at lists.zeromq.org
>> http://lists.zeromq.org/mailman/listinfo/zeromq-dev



More information about the zeromq-dev mailing list