[zeromq-dev] Backport of ZMQ_RCVTIMEO/ZMQ_SNDTIMEO to 2.1.x

[MinRK]

Does adding to the API/ABI really make sense at this late point in the
2.1.x series?  This will be the first such change since the first stable
2.1 release, as far as I know.

I thought patch releases were only meant to contain bugfixes, etc., not API
expansion.  It's fine if API/ABI are officially not fixed per major.minor,
but that seems to have been practice until this point, even if only by
coincidence.

-MinRK

On Fri, Mar 30, 2012 at 17:21, Pieter Hintjens <ph at imatix.com> wrote:

> Yes, that's the repo. Note that every change needs to be backed by an
> issue and a test case.
>
> Apart from the "can we change the ABI version number" question, it
> seems a good investment in 2.1.
>
> So my suggestion is, make an issue, make a test case, then make a pull
> request (please also update the ABI version number). I'll test it and
> then merge it to libzmq2-1 master.
>
> -Pieter
>
> On Fri, Mar 30, 2012 at 11:01 AM, Joshua Foster <jhawk28 at gmail.com> wrote:
> > Looking through the code, much of it has already been back ported as
> part of issue 231. Are we still using the
> https://github.com/zeromq/zeromq2-1 repository for the 2.1.x development?
> >
> > Joshua
> >
> > On Mar 30, 2012, at 11:55 AM, Pieter Hintjens wrote:
> >
> >> On Fri, Mar 30, 2012 at 10:26 AM, Joshua Foster <jhawk28 at gmail.com>
> wrote:
> >>
> >>> Does anyone have any problem if I back port the send/recv time out
> socket options to 2.1.x?
> >>
> >> Sounds like a great idea.
> >>
> >> We'll have to modify the ABI version. This may impact bindings.
> >>
> >> -Pieter
> >> _______________________________________________
> >> zeromq-dev mailing list
> >> zeromq-dev at lists.zeromq.org
> >> http://lists.zeromq.org/mailman/listinfo/zeromq-dev
> >
> > _______________________________________________
> > zeromq-dev mailing list
> > zeromq-dev at lists.zeromq.org
> > http://lists.zeromq.org/mailman/listinfo/zeromq-dev
> >
> _______________________________________________
> zeromq-dev mailing list
> zeromq-dev at lists.zeromq.org
> http://lists.zeromq.org/mailman/listinfo/zeromq-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.zeromq.org/pipermail/zeromq-dev/attachments/20120330/e1f3b40e/attachment.htm>