[zeromq-dev] Feedback on pubsub pull requests (trie/mtrie fixed, etc.)

Pieter Hintjens ph at imatix.com
Mon Jan 30 11:05:33 CET 2012


Staffan,

> Pieter asked me to ask for feedback on some pull requests which got merged
> to master, so here we go...

Thanks a lot for these important patches and the explanations.

A word of caution: the new policy of accepting any apparently sane
pull request means that there is no guarantee whatsoever these patches
will survive through to a stable version.

This applies to all patches: while it's easy to make a patch to
libzmq, it's just as easy for someone else to reverse it or change it.

Thus, I'd advise people to send patches early, rather than late, since
it takes about 6 months for new code to make its way into a stable
release. If you time it right, you can roll into production on a
stable release that contains the fixes you depend on.

Cheers
Pieter

Ps. for another perspective on the libzmq process, read
http://unprotocols.org/blog:19



More information about the zeromq-dev mailing list