[zeromq-dev] Fwd: Exact matching on subscription topics

[Staffan Gimåker]

Hi Martin,

On Wed, Jan 25, 2012 at 8:35 AM, Martin Sustrik <sustrik at 250bpm.com> wrote:

> Here's an initial go at this if anyone wants to have a look:
>>
>> https://github.com/gimaker/**libzmq/tree/exact-matching<https://github.com/gimaker/libzmq/tree/exact-matching>
>>
>> <https://github.com/gimaker/**libzmq/tree/exact-matching<https://github.com/gimaker/libzmq/tree/exact-matching>>It
>> probably needs
>> a bit more polish and documentation, but it'd be nice to get some
>> feedback if it's on the right track.
>>
>
> I've code-reviewed the patch. The code is nice and comprehensible, I can't
> find any flaw in it. So, I think there should be no problem with merging it
> into the trunk.
>
> One thought though: It looks like the amount of filtering code will grow
> up significantly with any new filtering mechanism. Is there a way to
> minimise that? For example, can we somehow unify the pub-side and sub-side
> filters?
>

Thanks for taking a look at this!

I couldn't really figure out a way to unify the pub and sub-side of the
filtering, no. Maybe if more templates/meta programming-tricks are ok I can
come up with something. The pub and sub side do things just differently
enough that it's tricky to unify it, but if anyone has any ideas I'm all
ears.

Regarding the filter mechanisms, I think it's a good idea to keep them few
and simple. A nice side-effect to a more modular approach to filtering is
that it's easier to maintain your own branch with your own funky filtering
mechanisms. Something we might end up doing to optimize things for our
specific problem, for example.

/S
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.zeromq.org/pipermail/zeromq-dev/attachments/20120125/065e6e1e/attachment-0001.htm>