[zeromq-dev] [PULL] x306: Implement ZMQ_TCP_KEEPALIVE* family of options to adjust TCP keepalives

Sergey Hripchenko shripchenko at intermedia.net
Mon Apr 9 17:35:36 CEST 2012


Please review & approve: https://github.com/zeromq/libzmq/pull/306.

  *   Will work where supported by OS(except of Windows). Someone(who knows Windows) could make it work on Windows with the following code:

tcp_keepalive alive;

alive.onoff = TRUE;

alive.keepalivetime = 60000;

alive.keepaliveinterval = 1000;

int bytes_ret=0;

res = WSAIoctl(socket, SIO_KEEPALIVE_VALS, &alive, sizeof(alive), NULL, 0,

    &bytes_ret, NULL, NULL);

  *   There was some objections against constants naming that is better to make them as much POSIX-like as we can. I could convert them, however:

ZMQ_TCP_KEEPALIVE

ZMQ_TCP_KEEPALIVE_CNT

ZMQ_TCP_KEEPALIVE_IDLE

ZMQ_TCP_KEEPALIVE_INTVL

Looks cleaner to me than:

ZMQ_SO_KEEPALIVE

ZMQ_TCP_KEEPCNT

ZMQ_TCP_KEEPIDLE

ZMQ_TCP_KEEPINTVL

However if you think that more POSIX-like naming is good - I can rename them.

  *   Documentation definitely should be more verbose. Someone who knows English better than me could enhance it taking my prev. commit(https://github.com/shripchenko/libzmq/commit/4b303402a76a5d2fe85ff8cdaf7a98d6dcfa94ee) as a starting point. Or kill it with fire and provide a new one.


________________________________

This message is intended only for the person(s) to which it is addressed and may contain Intermedia.net Inc privileged, confidential and/or proprietary information. If you have received this communication in error, please notify us immediately by replying to the message and deleting it from your computer. Any disclosure, copying, distribution, or the taking of any action concerning the contents of this message and any attachment(s) by anyone other than the named recipient(s) is strictly prohibited.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.zeromq.org/pipermail/zeromq-dev/attachments/20120409/128ce943/attachment.htm>


More information about the zeromq-dev mailing list