[zeromq-dev] sending possibly not crossplatform patches

Ian Barber ian.barber at gmail.com
Wed Apr 4 17:23:17 CEST 2012

On Wed, Apr 4, 2012 at 3:49 PM, Sergey Hripchenko <
shripchenko at intermedia.net> wrote:

>  Is it worth doing to send you patches that are not cross-platform(not
> even tested)
> (like for example implementation of ‘TCP keep-alives configuration’ via
> setsockopt() differs for almost each platform)
> I have no possibility to test and implement it for all platforms supported
> by zmq.
> Will you accept some zmq->socket()->setsockopt()’s that will work only on
> Linux for example.
> (and does nothing on other platforms? Just a place holder…)

I would put the patches together in your personal repository, and once you
have a set of options working issue the pull request, with an appropriate
set of defines to exclude them from the platforms that do not work. All
functionality in ZeroMQ should be as universal as it can be, so whether
those changes would get pulled into a stable release are the release
managers decision, but I would presume not unless they were widely
supported. Try to create tests which utilise the functionality - these will
be run across all the platforms on the build system which will help test
when they're merged to master.

Feel free to post links to your repository to discuss code as well if you
have questions about cross platform support, you will often get good
comments and feedback about proposals.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.zeromq.org/pipermail/zeromq-dev/attachments/20120404/3d5d15aa/attachment.htm>

More information about the zeromq-dev mailing list