[zeromq-dev] Binding contribution guidelines

Johnny Gozde johnny at jgoz.net
Sun Apr 1 08:08:16 CEST 2012


Hi all,

This question is mostly for Pieter, but it might apply to others.

Does the new libzmq contribution policy also apply to the bindings? I'm
only asking because Pieter merged a pull request on clrzmq before I had a
chance to review it. Aside from some minor formatting and naming issues
that needed cleaning up, the patch reverted an recent bug fix (presumably
accidentally), which I caught and corrected.

My preference would be to continue reviewing pull requests before merging
them into clrzmq, even if it incurs a small delay. But if Official ZeroMQ
projects are going to use the libzmq contribution policy, perhaps that
should be documented explicitly on the "Contributing" wiki page or on the
"Writing a binding" page. I would also need to revise my own process to
account for pull requests that other people have merged, possibly without
review.

Thanks,
John
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.zeromq.org/pipermail/zeromq-dev/attachments/20120401/e5e598fa/attachment.htm>


More information about the zeromq-dev mailing list