[zeromq-dev] czmq and zalloc - handling OOM situations

[AJ Lewis]

On Mon, Oct 03, 2011 at 07:15:10AM -0500, Pieter Hintjens wrote:
> Nice work. I have a few comments on style but the approach is the
> right one afaics and you can send pull requests when you like.

Great! I'll apply the below style changes to my changesets and then get
to work on the rest of the codebase.  

Is it easier to ingest if I send changesets as I go, or would you like
to get all the changesets once I think I've gotten all the zmalloc
handling changed?

> Style comments:
> 
> Don't use {} around single statements:
> 
>     if (!self) {
>         goto end;
>     }
> 
> Should be:
> 
>     if (!self)
>         goto end;
> 
> Put 'else' on new line:
> 
>     } else {
>         error = ENOMEM;
>     }
> 
> Should be:
> 
>     else
>         error = ENOMEM;
> 
> Use spaces around punctuation:
> 
>     assert(rc == 0);
> 
> Should be:
> 
>     assert (rc == 0);
> 
>     } else {
>         error = EINVAL;
>     }

Thank you!
-- 
AJ Lewis
Software Engineer
Quantum Corporation

Work:    651 688-4346

----------------------------------------------------------------------
The information contained in this transmission may be confidential. Any disclosure, copying, or further distribution of confidential information is not permitted unless such privilege is explicitly granted in writing by Quantum. Quantum reserves the right to have electronic communications, including email and attachments, sent across its networks filtered through anti virus and spam software programs and retain such messages in order to comply with applicable data security and retention requirements. Quantum is not responsible for the proper and complete transmission of the substance of this communication or for any delay in its receipt.