[zeromq-dev] [PATCH] Introduces bi-directional pipes
sustrik at 250bpm.com
Mon May 23 07:54:55 CEST 2011
Thanks for review!
> 1. I don't think you should leave a printf in the code (in owns.cpp).
> 2. Based on past experience with a similar structure, you should used a
> class policy instead of the N parameter in the array_t template. It
> would allow more flexible and clearer code. No need to remember what
> index_array1 and index_array2 mean.
It's cheap and nasty solution for the existing problem, namely that
pipes have to be stored in two arrays at the same time, with all the
array operations having O(1) complexity.
If you have a more elegant design, feel free to propose it.
More information about the zeromq-dev