[zeromq-dev] [PATCH] ZMQ_MULTICAST_HOPS socket option added

[Steven McCoy]

On 15 May 2011 12:29, Martin Sustrik <sustrik at 250bpm.com> wrote:

> Hi Steven,
>
> I've exposed PGM_MULTICAST_HOPS option from 0MQ API. The documentation was
> not clear about whether the option is of type 'int'.
>
>
It's missed on pgm(7) but it's mentioned in the remarks of pgm_setsockopt(2).
 I guess it's following typical Unix style of being vague :-)

http://code.google.com/p/openpgm/wiki/OpenPgm5CReferencePgmGetSockOpt


> Can you please check it?
>
>
You already have hops set on line 329 of pgm_socket.cpp, so the patch can be
smaller.  The default in ZeroMQ is 16, not 1, for Cisco hardware performance
workarounds, expiring packets on TTL is apparently expensive for some
routers.

-                  multicast_hops   = 16,
+                  multicast_hops   = (int) options.multicast_hops,

The order of socket options is odd because of the different socket levels
and follows Stevens' style.

-- 
Steve-o
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.zeromq.org/pipermail/zeromq-dev/attachments/20110515/31433e54/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Use-multicast-hops-option-on-PGM-sockets.patch
Type: text/x-patch
Size: 952 bytes
Desc: not available
URL: <https://lists.zeromq.org/pipermail/zeromq-dev/attachments/20110515/31433e54/attachment.bin>