[zeromq-dev] [PATCH] issue 211, REP socket futzing

[Pieter Hintjens]

Martin,

Any feedback on this patch, please? I'm planning a 2.1.7 release and
do want to get this code into master before then. You can always do it
"right" later, but the assert is unacceptable in production code IMO.

-Pieter


On Fri, May 6, 2011 at 5:18 PM, Pieter Hintjens <ph at imatix.com> wrote:
> Martin,
>
> Attached is a patch against 3.0 master that fixes, afaict, the
> assertion failure in REP sockets when they get messages lacking an
> envelope.
>
> The issue is here: https://github.com/zeromq/libzmq/issues/211
>
> The code doesn't close the connection, but it does discard the message
> and leave the state machine in the correct state. Tested with one
> valid client doing requests in a loop, and an invalid client trying to
> futz socket in parallel.
>
> Also done on 2.1 and 2.2, so no downstreaming required.
>
> -Pieter
>