[zeromq-dev] [PATCH] Remove Windows NT 3.5 support from zeromq2-1

[Steven McCoy]

On 16 June 2011 04:25, Dirkjan Ochtman <dirkjan at ochtman.nl> wrote:

> On Tue, Jun 14, 2011 at 09:32, Martin Sustrik <sustrik at 250bpm.com> wrote:
> > Let's drop it unless there's someone with NT3.4 box out there to test it.
>
> Isn't this the kind of thing that shouldn't be done on a stable branch
> (like zeromq2-1 currently)?
>
>
Note that the public headers of ZeroMQ do not support NT 3.5, so it is
already broken,

*zmq.h:*

#if defined _WIN32
#include "winsock2.h"
#endif

If you want NT 3.5 support here it should look like this, defining
WIN32_LEAN_AND_MEAN to avoid WinSock, bringing in *windows.h* to detect the
platform, then bringing in the correct WinSock version headers,

#if defined _WIN32
*#ifndef WIN32_LEAN_AND_MEAN
*
#define WIN32_LEAN_AND_MEAN
#endif
#include <windows.h>
*#if(_WIN32_WINNT >= 0x0400)*
*#include <winsock2.h>
#include <mswsock.h>
#else
#include <winsock.h>
*
*#endif /* _WIN32_WINNT >= 0x0400 */*
#endif /* _WIN32 */
*
*
-- 
Steve-o
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.zeromq.org/pipermail/zeromq-dev/attachments/20110616/63a037d1/attachment.htm>