[zeromq-dev] nmap patch for github issues 147+149

[Dhammika Pathirana]

Hi Thijs,

On Tue, Jan 18, 2011 at 1:41 AM, Thijs Terlouw <thijsterlouw at gmail.com> wrote:
>> From: Dhammika Pathirana <dhammika at gmail.com>
>> Subject: Re: [zeromq-dev] nmap patch for github issues 147+149
>>
>> Do you have a coredump?
>> Could you post a backtrace, run "thread apply all bt" in gdb.
>
> Hi, so far my patches are working good for me. No more coredumps. I've
> undone the patches though and only patched the "zmq_engine_t::error()"
> function as below. Without that patch it will already coredump on the
> zmq_assert(inout) and not reach the more interesting error:
>
> So I used this patch:
> =========patch:=========
> void zmq::zmq_engine_t::error ()
> {
>    if (plugged)
>    {
>        zmq_assert (inout);
>        inout->detach ();
>        unplug ();
>    }
>    if(ephemeral_inout)
>    {
>        ephemeral_inout->detach ();
>    }
>    delete this;  //do not delete, will cause dangling pointer
> }


ephemeral_inout is set when engine is about to move to a different IO thread.
I think it's better if we handle this error in receiver thread, in
process_attach command.
I'll send a patch shortly.


>
> then I run nmap as following:
> nmap -sV -n xxx.xxx.xxx.xxx -p 5550-5570


Thanks for the bug report and the patch.

Dhammika