[zeromq-dev] nmap patch for github issues 147+149

[Pieter Hintjens]

On Mon, Jan 17, 2011 at 1:51 PM, Thijs Terlouw <thijsterlouw at gmail.com> wrote:

> in the first attempt i didn't use the correct style guidelines, so I
> updated the code but now it results in two patch files. I cannot find
> a way to merge all changes into one patch, but at least it's
> signed-off now.

Ideally it'd be in an email with subject '[PATCH]...' so that it's
picked up by Martin.  You may find the patch ignored and need to
resubmit it.

> Regarding testing: I found only a few tests in the /tests/ directory.
> Did you consider adding more tests based on the Googletest unit
> testing framework? I have been using it lately and it's quite easy to
> use. Testing multi-threaded and networking code is always quite hard,
> but I could give it a try. The issues with nmap might also be found
> with some good unit tests.

It's an excellent idea, and would make testing rather more systematic.
If you can avoid dependencies at build time, sounds like it would
work.  Do you want to give it a shot?

-Pieter