[zeromq-dev] Publisher side filtering... (draft II )

[Gerard Toonstra]

Ok, Martin, thanks for that. It does look a lot better.

So, the idea is probably to wait a while to see if any problems pop up.

The remainder can be divided in two further steps:

1. The changes in the session only ensure that integrity is maintained after
reconnects or disconnects. So the app writer doesn't
    need to worry about re-issuing sub/unsub requests. The session in the
socket will do that on behalf of the user. Since this touches
    on the part of the session, I propose to do this last.

2. The xsub does not yet actually send the sub request upstream. So the
second patch could be to ensure that forwarding will start to work.
    This will then not handle disconnects/reconnects correctly as per 1.
Also, the order in which subscribers issue socket/setsockopt/connect
    commands has an impact on forwarding subscriptions or not. This is
because sub requests prior to a socket connection will store the requests
    in the session until a connection is available.


Agreed?  and how long to wait for the next patch to be issued?

Rgds,

G>

On Fri, Jan 14, 2011 at 12:45 PM, Martin Sustrik <sustrik at 250bpm.com> wrote:

> Hi Gerard,
>
> I've refactored the patch a bit.
>
> Namely I've extracted the "distribute to all pipes" policy from xpub socket
> (dist_t class). I've then used it in bot xpub_t (for message distribution)
> and in xsub_t (for passing subscriptions to all upstream peers).
>
>
>  Note that pipe management for XPUB is not yet done (the pipes necessary
>> to receive messages over the XPUB connection,
>> such that devices can receive the message and push this to XSUBs they
>> also implement). The intention is to use
>> the fq_t class later for that purpose.
>>
>
> I've added fq_t to xpub_t as proposed above.
>
> All of that is committed to the master. You are added to AUTHORS file.
>
> Martin
>



-- 
Gerard Toonstra
-----------------------
http://www.radialmind.org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.zeromq.org/pipermail/zeromq-dev/attachments/20110114/3f575122/attachment.htm>