[zeromq-dev] [PATCH] s390x support

Mikko Koppanen mikko.koppanen at gmail.com
Tue Jan 11 22:46:17 CET 2011


On Tue, Jan 11, 2011 at 1:45 PM, Martin Sustrik <sustrik at 250bpm.com> wrote:
> Hi,
>
> Re-sending the patch to the mailing list for the future record.
>
> Mikko, can you have a look at the build part of the patch?
>

Hello,

went through the patch and in general it looks very good and this
probably takes us closer to supporting more platforms with pgm (before
the autoconf build for pgm is fully usable).

I noticed the following things:

1. the additional functions are checked even if PGM extension is not being used

2. PGM_DEFINES is not used in the automake files, which causes build
to fail on at least linux

3. Instead of introducing another automake variable
LIBZMQ_EXTRA_CFLAGS can probably be used for passing the flags

I am attaching a slightly modified version of it as a diff.

-- 
Mikko Koppanen
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dynamic_generation.patch
Type: application/octet-stream
Size: 4893 bytes
Desc: not available
URL: <https://lists.zeromq.org/pipermail/zeromq-dev/attachments/20110111/955b1b3c/attachment.obj>


More information about the zeromq-dev mailing list