[zeromq-dev] binding a source addres for zmq_connect(). Second try.

Sergey Matveychuk sem33 at yandex-team.ru
Tue Dec 27 17:34:51 CET 2011


27.12.2011 15:15, Martin Sustrik wrote:
> Hi Sergey,
>
>> I've moved from 3.0 to 3.1, so I've got a chance to test my first patch
>> more. I've found a stupid bug in it and fixed resolve_interface()
>> function when it ignored an interface name.
>
> What was the problem with the first patch, btw? I've reviewed it and it
> looked OK.

Accsidently local scoped defined variable:
uint16_t port = (uint16_t) atoi (delimiter+1);
instead of
port = (uint16_t) atoi (delimiter+1);

Fortunately you did not commit the first patch. And with the second 
patch I fixed a bug with inteface names.

>
>> Here is my second patch. Please, comment it. May be you dislike the last
>> argument in zmq::tcp_address_t::resolve with a default value?
>
> I guess we should wait for Pieter to create zeromq-3.1 repository so
> that the patch goes there.
>
> Martin
>




More information about the zeromq-dev mailing list