[zeromq-dev] Assert on pgm_getsockopt (Win7 x64, ZMQ 2.1.7, OpenPGM 5.1.116 )

[Martin Sustrik]

On 08/17/2011 06:44 PM, Pieter Hintjens wrote:

> I can and will apply the patch, that's fine, but from experience it's
> safer to ask folk to file an issue first, so that we can track things,
> attach patches to a safe place, link to test cases, and properly
> maintain the NEWS files in stable releases. I'd also be happier if
> commits to master used issue numbers so that it's easier to track
> patches across the different versions.
>
> Small things, but we've learned we need them, or stuff breaks.

Yes. Understood. On the other hand, however, if I required a ticket and 
a test case for every error report before fixing it, lot of bugs won't 
get fixed at all. People tend to mention the error and then disappear if 
they are asked for any additional effort.

Also note that breaking the master doesn't really matter. It's a 
development version and isolating new and potentially harmfull patches 
from the stable codebases is the very reason for its existence.

Thus, I would say, let's fix all the bugs we can in the master. And 
apply a formal procedure for backporting to stable releases where any 
problem actually hurts.

Martin