[zeromq-dev] [PATCH] Message-related functionality factored out into msg_t class.

Martin Sustrik sustrik at 250bpm.com
Fri Apr 29 07:46:32 CEST 2011


On 04/27/2011 10:45 AM, Pieter Hintjens wrote:

>> At the point I post the patch it's not yet in the repo. I wait a day or two
>> so there is at least some time for review and apply it afterwards.
>>
>> In short, the link doesn't exist yet when I'm sending the email.
>
> Hmm, indeed. How about having it on a branch in libzmq, so others can
> fetch the branch and test it, and then after review, merging the
> branch to master?
>
> That lets you share the code, share links, and get not just code
> review but actual test results if needed.

Yes. That's topic branches. However, I would say that asking people to 
create a publicly accessible topic branch just to submit a patch is 
pretty big an entry barrier.

It makes sense for large patches. Not that much for small ones.

Martin



More information about the zeromq-dev mailing list