[zeromq-dev] [PATCH] Message-related functionality factored out into msg_t class.

[Pieter Hintjens]

OK, I have one review comment on this change.

Actually, two. The first is my usual complaint that a link to
https://github.com/zeromq/libzmq/commit/e0246e32d79d71f8e73207b43aed8b23648e4fc7
would be helpful and cheap.

My real comment is that you still define the zmq_msg_t structure publicly as:

  typedef unsigned char zmq_msg_t [32];

which kind of defeats the ability to change the structure by calling a
new library. I've explained how to use opaque types properly in C, is
there a reason you're not doing that?

-Pieter


On Thu, Apr 21, 2011 at 10:32 PM, Martin Sustrik <sustrik at 250bpm.com> wrote:
>
> _______________________________________________
> zeromq-dev mailing list
> zeromq-dev at lists.zeromq.org
> http://lists.zeromq.org/mailman/listinfo/zeromq-dev
>
>