[zeromq-dev] [PATCH] Message atomicity problem in PUB fixed (issue 191)

[Pieter Hintjens]

On Tue, Apr 26, 2011 at 3:09 PM, Martin Pales <m.pales at gmail.com> wrote:

> There is the "merge" button since yesterday :-)
> https://github.com/blog/843-the-merge-button

Aha... progress...

> I use gmail and it works great with attached patches. They are opened in an
> external editor (notepad++ in my case) and nicely syntax-highlighted.

I'll try again. Something in my configuration makes this not work
properly. If I review a commit on github, my only toolchain is the web
browser...

> I personally prefer this way over inlining them in emails.

If it works it's certainly OK. Inlining makes a mess of formatting.

> Regarding the github workflow using pull requests and posting a link here,
> it's also a very convenient way of collaboration. And needless to say it's
> much less work for commiters when using the merge button.

+1.

You also get a clear discussion thread that survives over time.

And you get workflow via the issue tracker.

-Pieter