[zeromq-dev] [PATCH] Message atomicity problem in PUB fixed (issue 191)

Martin Lucina mato at kotelna.sk
Tue Apr 26 14:38:46 CEST 2011


ph at imatix.com said:
> On Tue, Apr 26, 2011 at 12:44 PM, Martin Sustrik <sustrik at 250bpm.com> wrote:
> 
> > I have the changes on my local git. It's not accessible from the network.
> 
> If you worked on a fork of libzmq, and held that fork on github (on
> your own profile), it'd be accessible. This is the usual way of
> sharing patches.
> 
> > Aside of that, I really like the fact that people are forced to at least
> > have a look at the patch before applying it, instead of just mechanically
> > clicking on the 'apply' button.
> 
> Well, there is no "apply" button :-) At least I couldn't find one.
> It's quite a lot of work to apply a patch, and that's fine. What
> concerns me here is the work required to *review* a patch.

I presume you're using GMail; in Mutt I have no problem since the entire
text-only attachment of the patch is displayed inline.

It's true that the patches-over-email workflow may seem archaic, and it is
bound somewhat to using the right tools; if I wanted an "apply" button I
could make one trivially with a shell script. 

Maybe use a different mail client for reading zeromq-dev?

-mato



More information about the zeromq-dev mailing list