[zeromq-dev] [PATCH] Message atomicity problem in PUB fixed (issue 191)

[Pieter Hintjens]

On Tue, Apr 26, 2011 at 12:44 PM, Martin Sustrik <sustrik at 250bpm.com> wrote:

> I have the changes on my local git. It's not accessible from the network.

If you worked on a fork of libzmq, and held that fork on github (on
your own profile), it'd be accessible. This is the usual way of
sharing patches.

> Aside of that, I really like the fact that people are forced to at least
> have a look at the patch before applying it, instead of just mechanically
> clicking on the 'apply' button.

Well, there is no "apply" button :-) At least I couldn't find one.
It's quite a lot of work to apply a patch, and that's fine. What
concerns me here is the work required to *review* a patch.

> Yes. It should be donwstreamable. However, take care when applying it as
> there may be conflicts caused by the earlier patch, the one that factored
> out all the message related functionality to msg_t class.

Yes, we won't make the same mistake twice :-) That's guaranteed.

-Pieter