[zeromq-dev] [PATCH] Message atomicity problem in PUB fixed (issue 191)

[Pieter Hintjens]

Hi Martin,

It's great that you send patches to the list for review. IMO code
review is essential, and we don't do enough of it.

However I'd like to review patches like these by clicking on a link to
a git somewhere. Downloading and opening the patch into a text editor
is laborious and discouraging.

The usual process for git development, which most 0MQ projects seem to
follow, is to fork the git, then make pull requests back to the
original git. People can then review and discuss the pull requests.
Mikko has explained that github issues (including pull requests, which
are issues), can be exported. So there's no visible reason not to use
them.

Regarding this actual patch, it looks great and kudos to finding the
issue so quickly. Will we be able to downstream it to 2.1?

-Pieter

On Tue, Apr 26, 2011 at 8:32 AM, Martin Sustrik <sustrik at 250bpm.com> wrote:
>
> _______________________________________________
> zeromq-dev mailing list
> zeromq-dev at lists.zeromq.org
> http://lists.zeromq.org/mailman/listinfo/zeromq-dev
>
>