[zeromq-dev] ZMQ_MAKE_VALGRIND_HAPPY

[Martin Sustrik]

On 04/26/2011 09:24 AM, Pieter Hintjens wrote:

>> Mikko, is it possible to set ZMQ_MAKE_VALGRIND_HAPPY when --enable-debug
>> is set?

Sorry. I though it's possible to distribute suppression files with the 
library and make valgrind load the automatically.

Given that's not the case, this seems to be the next best solution. The 
downside, obviously, is that we have different setup for debug and 
release builds.

> This is an excellent idea, it's what I was asking for before we
> started working on a suppression file.
>
> Would it not make more sense to use something like "#ifdef DEBUG"
> rather than the VALGRIND specific macro, since the same initialization
> is necessary for other memory checking tools.
>
> And also:
>
> - debug is not enabled by default, IMO that should be done for all
> except stable releases
> - as far as I can tell there's only a single point in libzmq that
> actually needs this macro (the send method), most of the conditionals
> may be unnecessary

It's also needed in command passing routines.

> - there's no DEBUG macro defined yet when debug is enabled

The remaining points should be answered by Mikko and/or Mato.

Martin