[zeromq-dev] [PATCH] Add VERSION macros
Martin Lucina
mato at kotelna.sk
Mon Oct 11 22:28:09 CEST 2010
gdiethelm at dcv.cl said:
> > > >> How about this patch? It creates a single place where the version
> is
> > > >> kept; you don't have to change configure.in anymore.
> > > >>
> > > >> If there is consensus, I could push this into the master repo.
> > > >
> > > > Having an extra include file around doesn't feel right either;
> > >
> > > Atually, Gonzalo's patch can be modified to pick the version from
> zmq.h.
> > >
> > > That would solve all the problems we have, no?
> >
> > Right, so the source of the version number would be include/zmq.h,
> > configure.in would get it from there and propagate it to Makefile and
> > friends. Not an entirely bad idea.
>
> As long as including zmq.h from platform.hpp is OK, then I think we have
> agreed on a solution. Great!
>
> > Ok, we can do this, but as the resident autoconf and shell expect I'll
> > make
> > the actual patch using suitably paranoid UNIX commands, test on
> Solaris,
> > etc...
>
> So, do you want to take care of this, or should I go ahead and commit my
> patch first?
I'll take care of it tomorrow.
-mato
More information about the zeromq-dev
mailing list