[zeromq-dev] [PATCH] Add VERSION macros

Martin Sustrik sustrik at 250bpm.com
Mon Oct 11 17:22:19 CEST 2010

On 10/11/2010 05:19 PM, Martin Lucina wrote:
> gdiethelm at dcv.cl said:
>>> I guess I should have reviewed your change closely, but then you
>> obviously
>>> didn't react to that careful comment :-)
>>> At this time I will also note my unhapiness with the choice that
>> because
>>> of
>>> MSVC the version numbering now has to be manually updated in zmq.h
>> itself.
>>> But you insisted, so be it.
>> How about this patch? It creates a single place where the version is
>> kept; you don't have to change configure.in anymore.
>> If there is consensus, I could push this into the master repo.
> Having an extra include file around doesn't feel right either;

Atually, Gonzalo's patch can be modified to pick the version from zmq.h.

That would solve all the problems we have, no?


More information about the zeromq-dev mailing list