[zeromq-dev] [PATCH] Add VERSION macros

Martin Lucina mato at kotelna.sk
Mon Oct 11 17:19:28 CEST 2010


gdiethelm at dcv.cl said:
> > I guess I should have reviewed your change closely, but then you
> obviously
> > didn't react to that careful comment :-)
> > 
> > At this time I will also note my unhapiness with the choice that
> because
> > of
> > MSVC the version numbering now has to be manually updated in zmq.h
> itself.
> > But you insisted, so be it.
> 
> How about this patch? It creates a single place where the version is
> kept; you don't have to change configure.in anymore.
> 
> If there is consensus, I could push this into the master repo.

Having an extra include file around doesn't feel right either; what I'd
like to see (and I'm not sure why Martin does not like this), is that zmq.h
has variable substition done on it, i.e. a zmq.h.in is in the Git repo and
the build system creates the real zmq.h.

The only problem here is Windows, as usual, and it's lack of any tool that
lets us do sensible variable substitution. So any such tool would be an
extra dependency for people wanting to build on Windows.

I'm actually wondering whether or not it's worth investigating something
like CMake; if the added value it can provide is

a) a fully integrated build for all platforms (i.e. *one* single build
definition)

b) variable substitution and generation of files during build to allow for
things like ZMQ_VERSION

c) provision for running our test suite on all platforms. At the moment we
have no equivalent to "make check" on Windows.

I would consider switching build systems if we can find one that satisfies
all of the above. If not, the Windows build will always be some kind of
hack.

-mato




More information about the zeromq-dev mailing list