[zeromq-dev] [PATCH] Add VERSION macros

[Martin Lucina]

sustrik at moloch.sk said:
> On 10/06/2010 05:44 PM, gonzalo diethelm wrote:
> > Martin, when do you plan to apply this patch (to both maint and master)?
> > It would be great to have the mechanism in place; I think we can iron
> > out any wrinkles later. Thanks!
> >    
> 
> Tha patch is applied to both maint and master. As advertised, the macros 
> look like this:

Hmm, I just realised you broke "make dist" since it uses PACKAGE_VERSION in
the Makefile to do some substitutions on the Redhat packaging.

Can you please put back the following two lines on both maint and master?

# This lets us use PACKAGE_VERSION in Makefiles
AC_SUBST(PACKAGE_VERSION)

I guess I should have reviewed your change closely, but then you obviously
didn't react to that careful comment :-)

At this time I will also note my unhapiness with the choice that because of
MSVC the version numbering now has to be manually updated in zmq.h itself.
But you insisted, so be it.

-mato