[zeromq-dev] [PATCH] Add VERSION macros

[Martin Sustrik]

Hi Gonzalo,

> 0. You don't really need the PACKAGE_VERSION_XXX macros? They looked (to
> this noob) like a standard thing...

Dunno. They were generated by hand.

> 1. I would change "Place any MSVC-specific definitions here" into "Place
> any Windows-specific definitions here".

The file in question is used only by MSVC build. MinGW and Cygwin builds 
use the standard autotools-generated platform.hpp

> 2. I believe there is still a reference to hard-coded version numbers in
> configure.in:
>
>      AC_INIT([zeromq],[2.1.0],[zeromq-dev at lists.zeromq.org])

Autotools still needs to know the version number. If has to be changed 
at 2 places each time new version is produced: zmq.h and configure.in

> 3. It might be a good idea to be able to fetch the value of ZMQ_VERSION
> (the 20010) by calling a function, so that the caller (bindings) don't
> have to re-implement that logic. Perhaps a fourth parameter to
> zmq_version(), or as its return value?

I actually like the fact that the integer representation of version is 
hidden to applications. That allows us to change the algorithm in the 
future if the current one proves insufficient.

Martin