[zeromq-dev] [PATCH] Add VERSION macros

gonzalo diethelm gdiethelm at dcv.cl
Mon Oct 4 22:17:34 CEST 2010

> Here's the patch to maint to allow to determine 0MQ version on
> time.
> Review appreciated.

Looks good to me. A few remarks:

0. You don't really need the PACKAGE_VERSION_XXX macros? They looked (to
this noob) like a standard thing...

1. I would change "Place any MSVC-specific definitions here" into "Place
any Windows-specific definitions here".

2. I believe there is still a reference to hard-coded version numbers in

    AC_INIT([zeromq],[2.1.0],[zeromq-dev at lists.zeromq.org])

3. It might be a good idea to be able to fetch the value of ZMQ_VERSION
(the 20010) by calling a function, so that the caller (bindings) don't
have to re-implement that logic. Perhaps a fourth parameter to
zmq_version(), or as its return value?

Gonzalo Diethelm

More information about the zeromq-dev mailing list