[zeromq-dev] [PATCH] build related patches

Martin Lucina mato at kotelna.sk
Thu Nov 25 19:00:16 CET 2010


Hi Mikko,

mikko.koppanen at gmail.com said:
> again a list of patches:
> 
> 0001
> After this patch users should be able to override all build flags.
> Also fixes overriding CPPFLAGS for HP-UX build

Looks good. I presume you remove the initialisation of
LIBZMQ_EXTRA_C[XX]FLAGS at the beginning of configure.in so that these can
be overriden?

> 0002
> Call AC_REQUIRE from AC_CONFIG_LIBTOOL rather than fail the build

What does AC_REQUIRE actually mean?

> 0003
> New configure switch --enable-debug which turns off compiler
> optimizations and disables shared libraries

This is good but please make it so that it doesn't muck with the shared
library setting. We already have --enable-shared/--disable-shared so anyone
who wants a specific combination can use that.

Also I'm still in the dark as to how the AC_REQUIRE stuff works, it's now
slightly less obvious what order things get called in, but I guess as long
as it works that's not too big an issue.

-mato



More information about the zeromq-dev mailing list