[zeromq-dev] [PATCH] Preliminary Android support for trunk ZeroMQ

[Martin Sustrik]

Hi Ghislain,

Thanks for explanation!
> Android is mostly a Linux flavour, which unfortunately still requires a
> non standard toolchain, called the NDK. This toolchain defines the
> ANDROID variable, so I hadn't proposed a ZMQ_HAVE_ANDROID variable.
>    

Ok. So AFAIU autotools cannot be used to build 0MQ for Android anyway.
> The only difference I have found with a standard linux platform is in
> the incomplete support of the POSIX functions for optimizations, so I
> commented them out in my proposed patch.
>
> The specific toolchain also requires a specific directory structure.
> Therefore, I don't think the specific support for a complete build of an
> Android flavour should be integrated in the zmq trunk. However, it would
> be nice to have the trunk modified so that the source files could be
> directly copied into a NDK project.
What exactly would that mean?

Also, wouldn't it make sense to make the parts you've commented out 
enclosed in ifdefs?

#if ZMQ_HAVE_POSIX_FADVISE
    posix_fadvise (...);
#endif

Martin