[zeromq-dev] [PATCH] FD_SETSIZE increased for win32

[Martin Lucina]

sustrik at 250bpm.com said:
> On 11/04/2010 12:35 PM, Pieter Hintjens wrote:
> 
> >> +#ifndef FD_SETSIZE
> >> +#  define FD_SETSIZE 1024
> >> +#endif
> 
> Applied.

On Windows Server 2003, Visual Studio Express 2008, 32-bit Debug build,
this produces a crash on startup in every application including local_thr:

First-chance exception at 0x1007235c (libzmq.dll) in local_thr.exe: 0xC0000005: Access violation writing location 0x00368274.
Unhandled exception at 0x1007235c (libzmq.dll) in local_thr.exe: 0xC0000005: Access violation writing location 0x00368274.

libzmq.dll!zmq::select_t::select_t()  Line 50 + 0x6c bytes	C++
libzmq.dll!zmq::io_thread_t::io_thread_t(zmq::ctx_t * ctx_=0x00365ff8, unsigned int slot_=0)  Line 32 + 0x30 bytes	C++
libzmq.dll!zmq::ctx_t::ctx_t(unsigned int io_threads_=1)  Line 59 + 0x38 bytes	C++
libzmq.dll!zmq_init(int io_threads_=1)  Line 234 + 0x30 bytes	C++
local_thr.exe!main(int argc=4, char * * argv=0x00365f60)  Line 48 + 0xa bytes	C++
local_thr.exe!__tmainCRTStartup()  Line 586 + 0x19 bytes	C
local_thr.exe!mainCRTStartup()  Line 403	C
kernel32.dll!77e6f23b() 	
[Frames below may be incorrect and/or missing, no symbols loaded for kernel32.dll]	

If I remove the change, everything works again. If I put it back but try a
value of 256, it breaks again.

I'm guessing this is because in fact the value must be identical for the
entire compliation unit (at least libzmq.dll).

Please revert this, take this patch through as much review and testing as
is required for consensus and *then* apply it.

Thanks.

-mato