[zeromq-dev] [patch] 0001-Added-support-for-latest-OpenPGM-5.1.99-on-OSX10.6.patch

Scott alcoholiday at gmail.com
Tue Dec 21 18:34:46 CET 2010


On Tue, Dec 21, 2010 at 1:44 AM, Steven McCoy <steven.mccoy at miru.hk> wrote:
> On 21 December 2010 16:26, Scott <alcoholiday at gmail.com> wrote:
>>
>> +
>>
>> +PGMEXTRASOURCE = \
>> +       ../foreign/openpgm/@pgm_basename@/openpgm/pgm/getprotobyname.c \
>> +       ../foreign/openpgm/@pgm_basename@/openpgm/pgm/getnetbyname.c
>> +
>>  noinst_LTLIBRARIES = libpgm.la
>>
>>  nodist_libpgm_la_SOURCES =
>> ../foreign/openpgm/@pgm_basename@/openpgm/pgm/thread.c \
>> @@ -49,7 +54,8 @@ nodist_libpgm_la_SOURCES =
>> ../foreign/openpgm/@pgm_basename@/openpgm/pgm/thread.
>>     ../foreign/openpgm/@pgm_basename@/openpgm/pgm/galois_tables.c \
>>     ../foreign/openpgm/@pgm_basename@/openpgm/pgm/wsastrerror.c \
>>     ../foreign/openpgm/@pgm_basename@/openpgm/pgm/histogram.c \
>> -    ../foreign/openpgm/@pgm_basename@/openpgm/pgm/version.c
>> +    ../foreign/openpgm/@pgm_basename@/openpgm/pgm/version.c \
>> +    $(PGMEXTRASOURCE)
>>
>
> I'm not seeing the prevalence for PGMEXTRASOURCE?
>

These are files that are in the new version of the openpgm library, so
this was how I made them conditional.

>>
>> +if ON_DARWIN
>> +libpgm_diff_flags = \
>> +       -DCONFIG_BIND_INADDR_ANY \
>
> ...
>>
>> +       -DCONFIG_HAVE_ALLOCA_H \
>>
>> +       -DCONFIG_HAVE_BACKTRACE \
>>
>> +       -DCONFIG_HAVE_PROC \
>>
>> -DCONFIG_HAVE_GETTIMEOFDAY=1 -DCONFIG_HAVE_FTIME
>
> I don't think these should be here for Darwin, the latter two are covered
> by pgm/impl/features.h.

Yes they are - but pgm/impl/features.h is incorrectly (I believe)
interpreting the _POSIX or __POSIX flags and setting
CONFIG_HAVE_CLOCK_GETTIME


>>
>> +else
>>  libpgm_diff_flags = \
>>     -DCONFIG_HAVE_GETPROTOBYNAME_R2 \
>>     -DCONFIG_HAVE_ISO_VARARGS \
>> @@ -225,8 +256,10 @@ libpgm_diff_flags = \
>>     -DCONFIG_HAVE_SPRINTF_GROUPING \
>>     -DCONFIG_HAVE_VASPRINTF \
>>     -DCONFIG_BIND_INADDR_ANY \
>> -    -DCONFIG_HAVE_GETOPT
>> -endif
>> +    -DCONFIG_HAVE_GETOPT \
>> +    -DPGM_GNUC_INTERNAL=
>> +endif !ON_DARWIN
>> +endif !ON_MINGW
>>
>
> You should add for the default case (Linux & Solaris)
>  -DCONFIG_HAVE_POSIX_SPINLOCK, and -DCONFIG_HAVE_GETNETENT should be in
> there even though I messed it up upstream.
>

OK - I'll add them, but I can't test them.

Which reminds me, I have a question about how we're linking with
openpgm that I'll put in it's own thread.

> On 21 December 2010 16:49, Scott <alcoholiday at gmail.com> wrote:
>>
>> Well... after a little testing, I find that it's exploding when I try
>> to do a connect("epgm://en1;293.192.192.192:5000"), so we're not quite
>> there yet! At the same time openpgm  does compile and complete its
>> tests.
>
> Run with PGM_MIN_LOG_LEVEL=TRACE for extra output, DEBUG level only works in
> debug build and will give you even more output.
> I'm assuming that 293.192.192.192 is a typo, valid multicast addresses
> are 224.0.0.0 to 239.255.255.255.

Well spotted, yep - typo. Should have been 239.192.192.192

In general, super impressed with the whole zeromq library!

> --
> Steve-o
> _______________________________________________
> zeromq-dev mailing list
> zeromq-dev at lists.zeromq.org
> http://lists.zeromq.org/mailman/listinfo/zeromq-dev
>
>



More information about the zeromq-dev mailing list