[zeromq-dev] Thinking of...failure

[Conrad Steenberg]

You're right, see attached...

On Mon, 2009-08-10 at 10:22 +0200, Pavol Malosek wrote:
> Hello Conrad,
> 
> Seems like your attached patch is not complete since only setting
> reconnect_flag to false will cause tcp engine not to reconnect at all.
> 
> This is what I see in zmq-tcp_reconnect.diff file
> 
> --- libzmq/bp_tcp_engine.cpp.orig       2009-07-24 15:03:15.537908229 -0700
> +++ libzmq/bp_tcp_engine.cpp    2009-07-24 15:05:38.934659283 -0700
> @@ -36,7 +36,7 @@
>      pipe_cnt (0),
>      poller (NULL),
>      local_object (local_object_),
> -    reconnect_flag (true),
> +    reconnect_flag (false),
>      state (engine_connecting),
>      socket (hostname_)
>  {
> 
> malo
> 
> ----- Original Message ----- 
> From: "Conrad Steenberg" <conrad.steenberg at gmail.com>
> To: "Mu-Chi Sung (宋牧奇)" <nctusdk at gmail.com>
> Cc: <zeromq-dev at lists.zeromq.org>
> Sent: Monday, August 10, 2009 3:22 AM
> Subject: Re: [zeromq-dev] Thinking of...failure
> 
> 
> > Hi Mu Chi,
> >
> > Attached is a simple patch that does the first 2 things on my list
> > further down in the thread:
> > - it removes the abort() entirely,
> > - reconnects if no error handler exists
> > - reconnects/shuts connection down if the error handler returns
> > true/false.
> >
> > Still working on the rest, it's a little more convoluted than just
> > removing the queues/exchanges from the vectors in api_thread.
> >
> > HTH,
> > Conrad
> >
> > On Mon, 2009-08-10 at 07:40 +0800, Mu-Chi Sung (宋牧奇) wrote:
> >> Hi Conrad,
> >>
> >> I accidentally ran into the same issue as yours when I started
> >> thinking about failure, which is something I can't ignore from the
> >> design perspective.
> >> So could you post the patch to the list? Thanks a million!
> >> 
> _______________________________________________
> zeromq-dev mailing list
> zeromq-dev at lists.zeromq.org
> http://lists.zeromq.org/mailman/listinfo/zeromq-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: zmq-tcp_handler.diff
Type: text/x-patch
Size: 1137 bytes
Desc: not available
URL: <https://lists.zeromq.org/pipermail/zeromq-dev/attachments/20090810/68cd7873/attachment.bin>