[zeromq-dev] Fwd: Warnings as errors and gcc 4.3

Martin Sustrik sustrik at fastmq.com
Tue Apr 28 11:09:43 CEST 2009


> The code in question is pretty bad coding style though, it's not Python,

Pretty awful, eh? :)

There's refactoring going on in the domain of I/O threads right now and 
the code in question was meant as a scaffolding till the next batch of 
changes gets into mainline.

Mea culpa. I should be more careful when messing with trunk.

Martin

> 
> poll_thread.cpp
>         if (pollset [i].revents & POLLIN)
>             if (engine)
>                 engine->in_event ();
>             else
>                 if (!poller_->process_commands ())
>                     return true;
> 
> epoll_thread.cpp
>         if (ev_buf [i].events & EPOLLIN)
>             if (pe->engine)
>                 pe->engine->in_event ();
>             else
>                 if (!poller_->process_commands ())
>                     return true;
> 
> select_thread.cpp
>         if (FD_ISSET (fds [i].fd, &readfds))
>             if (fds [i].engine)
>                 fds [i].engine->in_event ();
>             else
>                 if (!poller_->process_commands ())
>                     return true;
> 
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> zeromq-dev mailing list
> zeromq-dev at lists.zeromq.org
> http://lists.zeromq.org/mailman/listinfo/zeromq-dev




More information about the zeromq-dev mailing list