[zeromq-dev] 0.4 release
Martin Sustrik
sustrik at fastmq.com
Thu Nov 20 11:26:43 CET 2008
Hi George,
>> Cmake patch is irrelevant for the release, so there's no reason for any
>> haste. Release will be packaged by autotools and distributed as such. cmake
>> patch will be merged into trunk and it will have no impact on the release
>> even if it is non-functional at the moment.
>
> Ok. BTW, I have been building AIX and HP/UX with cmake.
Yes. However, if we want to support these systems in 0.4 package, it
should be done via autotools as those are going to be used for the
distro creation.
>> OTOH, AIX & HP-UX ports do affect the release. That's why I've asked
>> specifically about them.
>>
>>> To build on HP/UX with the aCC compiler there were some additional
>>> compiler flags which need to be set (-AA -D_XOPEN_SOURCE=500
>>> -D_HPUX_SOURCE). You have already patched in the immediate "won't
>>> compile" stuff to trunk, so I think we are good there.
>> I would expect that at least ZMQ_HAVE_AIX and ZMQ_HAVE_HPUX macros should be
>> introduced into the code.
>>
>> Say a poll_thread is currently ifdef'd like this:
>>
>> #if defined ZMQ_HAVE_LINUX || defined ZMQ_HAVE_FREEBSD ||\
>> defined ZMQ_HAVE_OSX || defined ZMQ_HAVE_SOLARIS ||\
>> defined ZMQ_HAVE_OPENBSD || defined ZMQ_HAVE_QNXNTO
>>
>> If AIX and/or HP-UX support POSIX 'poll' function we should add them to the
>> ifdef.
Quick search seems to result in following: AIX supports 'select' and
'poll' -style polling. HP-UX should support 'select', 'poll' and
'/dev/poll'. Can you give it a try and let us know whether it builds OK?
The only thing that has to be changed is the #ifdef at the beginning of
poll_thread.hpp/cpp and devpoll_thread.hpp/cpp (select_thread has no
#ifdef as select seems to work on all the platforms).
> I can add HP/UX and AIX support to the autotools scripts if need be.
That would be really helpful given the work-in-progress status of cmake
build.
>> Malo will shortly merge your patch into the trunk, however, you have to
>> state it's licensed under MIT license first. Code with unclear licensing
>> cannot be merged into the project as it may jeopardise it's FOSS nature.
>
> I will certainly do that. I was hoping to get some feedback on the
> cmake patch then provide an official patch against ZMQ-112 stating
> it's MIT license.
Thanks!
>> Same applies to branches. We may create a branch in SVN for you,
however,
>> you would have to sign CAL first so that it's clear that any commits
you'll
>> do are properly licensed.
>
> I will work on getting a CAL agreement over to you guys.
Good news. Cooperating via SVN instead of sending patches back and forth
will make things much easier.
Regards.
Martin
More information about the zeromq-dev
mailing list