[zeromq-dev] zmq cmake patch

[George Neill]

Martin,

On Tue, Nov 18, 2008 at 4:47 AM, Martin Hurton <martin.hurton at gmail.com> wrote:
> On Mon, Nov 17, 2008 at 01:00:43PM -0500, George Neill wrote:
>> Martin,
>>
>> On Mon, Nov 17, 2008 at 12:48 PM, George Neill <georgen at neillnet.com> wrote:
>> > Martin,
>> >
>> > On Mon, Nov 17, 2008 at 11:31 AM, Martin Hurton <martin.hurton at gmail.com> wrote:
>> >> On Sun, Nov 16, 2008 at 09:04:25PM -0600, George Neill wrote:
>> >> Hi George,
>> >>
>> >> Thank you for the patch.
>> >> I get the following error when running cmake:
>> >> CMake Warning (dev) at cmake/zmq_macros.cmake:24 (add_executable):
>> >>
>> >> Is it ok? I was building on Debian lenny with cmake version 2.6.
>> >
>> > Yes, that should be fine.   I will install 2.6 and get any warnings
>> > fixed, sorry I did most of the work on the 2.4.8 version.
>>
>> I have updated the patch (http://www.bitshed.com/zmq.cmake.diff) , so
>> you shouldn't get that warning.
>
> Thanks George.
> Actually, I get more warnings this time. See the messages below.

Thank you for taking the time to look at this again.  Could you double
check the patch you applied?  The trunk/cmake/zmq_macros.cmake should
only have 84 lines in it, so I am confused by the warnings you have
sent below.

> - Martin
>
> CMake Warning (dev) at cmake/zmq_macros.cmake:90 (add_library):
>  Policy CMP0002 is not set: Logical target names must be globally unique.
>  Run "cmake --help-policy CMP0002" for policy details.  Use the cmake_policy
>  command to set the policy and suppress this warning.
> Call Stack (most recent call first):
>  zmq/CMakeLists.txt:99 (zmq_add_library)
> This warning is for project developers.  Use -Wno-dev to suppress it.
>
> CMake Warning (dev) at cmake/zmq_macros.cmake:108 (add_executable):
>  Policy CMP0002 is not set: Logical target names must be globally unique.
>  Run "cmake --help-policy CMP0002" for policy details.  Use the cmake_policy
>  command to set the policy and suppress this warning.
> Call Stack (most recent call first):
>  zmq/CMakeLists.txt:105 (zmq_add_executable)
> This warning is for project developers.  Use -Wno-dev to suppress it.


Thanks,
George.