[zeromq-dev] zeromq on windows patch

[Michael Greene]

Hi Martin,

Sorry for the repeat message.  The first one had the list left off.

> It's fixed and commited to both trunk and 0.4 branch.

Thanks, a fresh checkout of trunk now builds for me with the
appropriate VS settings.

> Some fixes are done. However, hardcoding paths this way
>
> - AdditionalIncludeDirectories="../../libzmq"
> + AdditionalIncludeDirectories="../../libzmq;C:\Python26\include"
>
> is no way to go. To set up the directories open the MSVC GUI and go to
> Tools/Options/Projects and Solutions/VC++ Directories and fill the paths in
> there.

I agree.  As I was following the existing template in DEBUG for the
RELEASE version, I'd like to suggest that lines 63 and 43 of
windows/libpyzm/libpyzmq.vcproj have this same hardcoded path removed.

>> I would also like to suggest that svn:ignore properties be added to
>> prevent the many build artifacts from showing up in svn.  This isn't
>> done in the non-Windows path either, so maybe it is not as much of an
>> issue for other developers - but it's a nice feature of subversion.
>
> This is pretty hard to achieve given that intermediary files may vary
> between platforms, compilers etc.

It does have the potential to take onerous work to achieve, but can be
done.  Sometimes it is as simple as appending the contents of svn
status on a built working copy to the svn:ignore property.  One of the
advantages of svn:ignore is that it can be set incrementally -- not
all intermediate files need to be identified in one fell swoop.
Though zeromq supports many environments, the set of possible
intermediate files is discrete and quite finite.  If it is a matter of
priorities and time, then I understand.

Regards,
Michael Greene